Skip to content

Make .bind(null, ...) work on autobound methods#268

Merged
sebmarkbage merged 1 commit intofacebook:masterfrom
sophiebits:bind-null
Aug 16, 2013
Merged

Make .bind(null, ...) work on autobound methods#268
sebmarkbage merged 1 commit intofacebook:masterfrom
sophiebits:bind-null

Conversation

@sophiebits
Copy link
Copy Markdown
Collaborator

Fixes #266.

@sophiebits
Copy link
Copy Markdown
Collaborator Author

cc @petehunt

Comment thread src/core/ReactCompositeComponent.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to make .bind(undefined, ...) work as well, then we should update the commit message.

@sophiebits
Copy link
Copy Markdown
Collaborator Author

I guess there's no reason to take undefined? Updated the commit.

@zpao
Copy link
Copy Markdown
Member

zpao commented Aug 16, 2013

Excellent. @sebmarkbage is going to pull this in to grow our group of people who can handle merges.

sebmarkbage added a commit that referenced this pull request Aug 16, 2013
Make .bind(null, ...) work on autobound methods
@sebmarkbage sebmarkbage merged commit 02f618d into facebook:master Aug 16, 2013
bvaughn added a commit to bvaughn/react that referenced this pull request Aug 13, 2019
Fixed build chrome not working on Windows due to rm command not existing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.bind(null, ...) should work on autobound methods for partial application

3 participants